Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString ......................................................................
Patch Set 3: > > What about std::ostream& operator<<(std::ostream& o, const Slice& > > s) in slice.h, line 281? This is legit. Since it's part of the client API, we should hunt down the references and update them. Eclipse says there's only one: the big LOG(FATAL) statement in RowSetInfo::CollectOrdered(). > Also, what is the plan to deal with > > string OutboundTransfer::HexDump() in transfer.cc, line 242? > Should usage of Slice::ToDebugString() be redacted in that call > site or there is a plan to deal with OutboundTransfer::HexDump() > at the higher levels? I could have sworn I saw one of Dan's patches that dealt with this using KUDU_SHOULD_REDACT(). -- To view, visit http://gerrit.cloudera.org:8080/5568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
