Dan Burkert has posted comments on this change. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString ......................................................................
Patch Set 3: (3 comments) > I could have sworn I saw one of Dan's patches that dealt with this using > KUDU_SHOULD_REDACT(). It's done in this patch. > What about std::ostream& operator<<(std::ostream& o, const Slice& s) in > slice.h, line 281? We had one caller, I fixed it up to redact and us ToDebugString explicitly. http://gerrit.cloudera.org:8080/#/c/5568/3//COMMIT_MSG Commit Message: > Is it worth adding a unit test to would verify that the data returned by Sl I think we have coverage of this. http://gerrit.cloudera.org:8080/#/c/5568/1/src/kudu/common/encoded_key.cc File src/kudu/common/encoded_key.cc: Line 188: } > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/5568/1/src/kudu/common/key_encoder.h File src/kudu/common/key_encoder.h: Line 97: Arena* /*arena*/, > warning: parameter 'arena' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/5568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
