Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString ......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString The Slice::ToDebugString method is used pervasively to log errors in the case of malformed inputs, which almost always can contain sensitive user data. Unfortunately Slice::ToDebugString is part of our public client API, so the redaction can not be done centrally in ToDebugString itself. Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034 Reviewed-on: http://gerrit.cloudera.org:8080/5568 Reviewed-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/block_compression.cc M src/kudu/cfile/bloomfile.cc M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/compression_codec.cc M src/kudu/common/encoded_key.cc M src/kudu/common/key_encoder.h M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/row_changelist.cc M src/kudu/consensus/log_util.cc M src/kudu/rpc/serialization.cc M src/kudu/rpc/transfer.cc M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/concurrent_btree.h M src/kudu/tablet/delta_key.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/lock_manager.cc M src/kudu/tablet/rowset_info.cc M src/kudu/util/slice.cc 21 files changed, 118 insertions(+), 80 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
