David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics ......................................................................
Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6451/7/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: PS7, Line 359: it is they are PS7, Line 360: by s/by/to http://gerrit.cloudera.org:8080/#/c/6451/7/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS7, Line 302: the highest index to be added to the leader's WAL. this is only appended below, right? also might not be highest (rewriting). I don't think it matters in terms of "correctness" I'd just rephrase to (here and elsewhere); If LEADER, also update the index of the last appended operation. PS7, Line 607: last_idx_appended_by_leader this needs to be the max you've taken above, no? http://gerrit.cloudera.org:8080/#/c/6451/7/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS7, Line 1150: Update the lag metrics while the contents of the request are still fresh from the leader. How about: Update lag metrics. We do it here instead of when appending to the queue below so to be able to update lag metrics even when operations are rejected. -- To view, visit http://gerrit.cloudera.org:8080/6451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8e992cc2397ca8d5873e62961a65f618d52c36 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
