Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/8/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS8, Line 309: pdate the index of the last appended operation. This must also be in the unlocked : // section to avoid any races with LocalPeerAppendFinished(), which updates metrics. : if (queue_state_.mode == LEADER) { : queue_state_.last_idx_appended_to_leader = last_id.index(); : } Actually this doesn't make sense, will move it back. There is a race, but it's in a test, not here. -- To view, visit http://gerrit.cloudera.org:8080/6451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8e992cc2397ca8d5873e62961a65f618d52c36 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
