Todd Lipcon has posted comments on this change. Change subject: interval_tree: allow bulk queries ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree-inl.h File src/kudu/util/interval_tree-inl.h: PS4, Line 248: into > into those Done PS4, Line 275: rem_queries > explain what this is. Done http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree-test.cc File src/kudu/util/interval_tree-test.cc: Line 100: return -compare(b, a); > warning: parameter 'b' is passed by value and only copied once; consider mo changed to const refs PS4, Line 239: TEST_F(TestIntervalTree, TestBigO) { > can you make this parameterized and do (small ints, big qs) (big ints, big hmm, not quite following what you mean. The for loops on line 247 and 250 don't cover this? http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree.h File src/kudu/util/interval_tree.h: PS4, Line 122: 1 > 3 Done PS4, Line 132: ItType begin_queries, : ItType end_queries, > so the point is to not make this dependent on vector or something? feel lik changed it to be a templated 'Container' type. You're right it's a typically but I think just saying it has to be an "STL Container" is clear enough. The ITNode<>::ForEachIntervalContainingPoints() still takes a pair of iterators serving as an STL range because the range changes as we recurse down the tree -- To view, visit http://gerrit.cloudera.org:8080/6481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4da25ca43413fbcae631a7b0f3f16062e4e408 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
