David Ribeiro Alves has posted comments on this change. Change subject: interval_tree: allow bulk queries ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree-test.cc File src/kudu/util/interval_tree-test.cc: PS4, Line 239: TEST_F(TestIntervalTree, TestBigO) { > hmm, not quite following what you mean. The for loops on line 247 and 250 d I was referring to that if we want to get benchmark numbers from this we usually measure run times so using those params would allow us to start benching this (instead of having a single run that does everything). If you don't think it's worth it that's ok http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree.h File src/kudu/util/interval_tree.h: PS4, Line 132: const QueryContainer& queries, : const Callback& cb) > changed it to be a templated 'Container' type. You're right it's a typicall still haven't addressed my naming concern. how about "queries_begin" and queries_end" -- To view, visit http://gerrit.cloudera.org:8080/6481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4da25ca43413fbcae631a7b0f3f16062e4e408 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
