Todd Lipcon has posted comments on this change. Change subject: interval_tree: allow bulk queries ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree-test.cc File src/kudu/util/interval_tree-test.cc: PS4, Line 239: TEST_F(TestIntervalTree, TestBigO) { > I was referring to that if we want to get benchmark numbers from this we us oh, check out what I did in the rowset_tree test in the next patch, hopefully that covers it. The actual CPU consumption of the RowSetTree lookup isn't a huge consumer in the benchmarks I ran - most of the perf stuff in this patch is to ensure we don't regress. The CPU improvement is icing on the cake. http://gerrit.cloudera.org:8080/#/c/6481/4/src/kudu/util/interval_tree.h File src/kudu/util/interval_tree.h: PS4, Line 132: const QueryContainer& queries, : const Callback& cb) > still haven't addressed my naming concern. how about "queries_begin" and qu you mean on ITNode? here in the public API I've changed it to just take the container. -- To view, visit http://gerrit.cloudera.org:8080/6481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4da25ca43413fbcae631a7b0f3f16062e4e408 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
