Adar Dembo has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags ......................................................................
Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt File build-support/lsan-suppressions.txt: PS5, Line 26: Adding this as a workaround since : # right now it's not clear what going on exactly If this warrants further investigation, could you file a JIRA and link to it here? PS5, Line 28: tests Got 'tests' twice in here. Line 30: leak:CreateAndStartTimeoutThread() Did the ScopedLeakCheckDisablers not work? http://gerrit.cloudera.org:8080/#/c/6795/5/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 157: Status s = ParseTriState("--rpc_authentication", FLAGS_rpc_authentication, &authentication); Can we CHECK_OK() here and below? The group validators are assumed to run after the regular gflag validators, and so if we are running this validator it should be safe to assume that --rpc_authentication and --rpc_encryption are valid, right? http://gerrit.cloudera.org:8080/#/c/6795/5/src/kudu/util/flag_validators.cc File src/kudu/util/flag_validators.cc: PS5, Line 30: custom group http://gerrit.cloudera.org:8080/#/c/6795/5/src/kudu/util/flag_validators.h File src/kudu/util/flag_validators.h: PS5, Line 42: starndard standard PS5, Line 55: indivigual individual PS5, Line 58: this Nit: 'the' (to be consistent with "Use the DEFINE_validator() macro...") Line 75: // GROUP_FLAG_VALIDATOR(groped_flags_validator, ValidateGroupedFlags); grouped_flags_validator Also, do you need to take the address of ValidateGroupedFlags (i.e. "&ValidateGroupedFlags")? PS5, Line 88: an a PS5, Line 88: validator validators (or "registers a group validator") -- To view, visit http://gerrit.cloudera.org:8080/6795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3755d62590cdc63a9d501ba69d980cb15f8069a9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
