Alexey Serbin has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags ......................................................................
Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt File build-support/lsan-suppressions.txt: PS5, Line 26: Adding this as a workaround since : # right now it's not clear what going on exactly > If this warrants further investigation, could you file a JIRA and link to i https://issues.apache.org/jira/browse/KUDU-1995 PS5, Line 28: tests > Got 'tests' twice in here. Done Line 30: leak:CreateAndStartTimeoutThread() > Did the ScopedLeakCheckDisablers not work? It works. Updated. http://gerrit.cloudera.org:8080/#/c/6795/5/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 157: Status s = ParseTriState("--rpc_authentication", FLAGS_rpc_authentication, &authentication); > Can we CHECK_OK() here and below? The group validators are assumed to run a Correct. We can put CHECK_OK http://gerrit.cloudera.org:8080/#/c/6795/5/src/kudu/util/flag_validators.cc File src/kudu/util/flag_validators.cc: PS5, Line 30: custom > group Done Line 37: void Register(const string& name, FlagValidator func) { > warning: the parameter 'func' is copied for each invocation but only used a Done http://gerrit.cloudera.org:8080/#/c/6795/5/src/kudu/util/flag_validators.h File src/kudu/util/flag_validators.h: PS5, Line 42: starndard > standard Done PS5, Line 55: indivigual > individual Done PS5, Line 58: this > Nit: 'the' (to be consistent with "Use the DEFINE_validator() macro...") Done Line 75: // GROUP_FLAG_VALIDATOR(groped_flags_validator, ValidateGroupedFlags); > grouped_flags_validator Done. With std::function it's not necessary to take the address, AFAIK. PS5, Line 88: an > a Done PS5, Line 88: validator > validators (or "registers a group validator") Done -- To view, visit http://gerrit.cloudera.org:8080/6795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3755d62590cdc63a9d501ba69d980cb15f8069a9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
