Alexey Serbin has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt File build-support/lsan-suppressions.txt: Line 30 > So either one works? Why use a suppression then? At least for TSAN, suppres It appeared to me that adding a suppression would be a cleaner way, not touching the source code. But since it seems to be temporary workaround, I think it does not matter that much. All right, let me put it back into the code (given that for TSAN supressions are more expensive that scoped leak disablers). -- To view, visit http://gerrit.cloudera.org:8080/6795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3755d62590cdc63a9d501ba69d980cb15f8069a9 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
