Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 17: (9 comments) http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: Line 105: ~FsManager(); > why have this instead of just passing in an FsManagerOpts with the appropri Yeah good point, this is only used in one place right now. Done http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 426: > worth DCHECKing here that data_dirs_.size() == 1? seems like it might be ea Done http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/integration-tests/multidir-cluster-itest.cc File src/kudu/integration-tests/multidir-cluster-itest.cc: Line 25: #include "kudu/gutil/map-util.h" > nit: alpha order Done PS16, Line 40: > Would you mind using ExternalMiniClusterITestBase for this test? It's what Yeah, Alexey made this point too, I was originally planning on extending this test for disk failure scenarios. Having added more disk failure tests, it probably makes sense to keep disk failure separate. Done Line 45: "--flush_threshold_mb=1", > maybe TestWorkload could do this just as well? Done Line 83: } > You can use TestWorkload.Setup() to easily create a table Done Line 103 > You should be able to get the same effect using TestWorkload.Start() and St Done Line 104 > This is potentially flaky. See below for a suggestion. Done PS16, Line 107: : : : : : : : : : : : : : > You can wrap this in ASSERT_EVENTUALLY() and avoid the potentially-flaky Sl Done -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
