Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 17: (5 comments) Yep, added the results to the commit message http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/disk_reservation-itest.cc File src/kudu/integration-tests/disk_reservation-itest.cc: Line 68: NO_FATALS(StartClusterWithOpts(opts)); > Looks like you can use this now: Done http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 422: // Delete files specified by 'wal_dir_' and 'data_dirs_'. > add: WARN_UNUSED_RESULT Done http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/master_failover-itest.cc File src/kudu/integration-tests/master_failover-itest.cc: Line 366: failed_master->DeleteFromDisk(); > ASSERT_OK() Done http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/multidir-cluster-itest.cc File src/kudu/integration-tests/multidir-cluster-itest.cc: Line 49: "--fs_target_data_dirs_per_tablet=0" > NO_FATALS() Done PS19, Line 88: }); : work.StopAndJoin(); : : // Check that WALs are being pla > Come to think of it, it wouldn't hurt to put this inside the ASSERT_EVENTUA Hrm, I'm trying to think of whether we can have a written blocks without having written to wal. I don't think so, but agreed, wouldn't hurt -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
