Adar Dembo has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 19: (6 comments) http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: Line 78: ADD_KUDU_TEST(multidir-cluster-itest) Nit: should come after master-stress-test, and should probably be called multidir_cluster-itest (dashed suffixes are reserved for kinds of tests). http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 255: CHECK_LE(*dir_index, opts_.num_data_dirs); Shouldn't this be CHECK_LT? If num_data_dirs=3, the only allowable values for dir_index should be 0, 1, and 2, right? Line 269: paths.push_back(GetDataPath(daemon_id, dir_index)); Nit: use emplace_back() here. http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 21: #include <boost/optional.hpp> Nit: this belongs in a separate group after the STL includes, because boost is part of the "Kudu project". Line 300: boost::optional<uint32_t> dir_index = boost::none) const; Any particular reason we're using uint32_t for this stuff and not 'int'? Line 428: DCHECK_EQ(1, data_dirs_.size()); Nit: Should probably be CHECK_EQ() given that the other checks you've added are not debug-only. -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
