Sam Okrent has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7111/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS1, Line 2020: MonoTime now = MonoTime::Now(); : if ((now - last_opened_container_log_time).ToSeconds() > 10) { : LOG(INFO) << Substitute("$0: opened $1 log block containers", : dir->dir(), local_report.stats.lbm_container_count); : last_opened_container_log_time = now; : } > Agreed, unless KLOG_EVERY_N_SECS() will log at the 0th second mark as well KLOG_EVERY_N_SECS() does log for the first container opened no matter how long it takes. In the new commit I'm not using it - let me know if you think I should. -- To view, visit http://gerrit.cloudera.org:8080/7111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dd5eccd166ae81be26d0aa75758539f84d62656 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-HasComments: Yes
