Alexey Serbin has posted comments on this change.

Change subject: KUDU-1442 log number of open log block containers
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7111/1/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

PS1, Line 2020:     MonoTime now = MonoTime::Now();
              :     if ((now - last_opened_container_log_time).ToSeconds() > 
10) {
              :       LOG(INFO) << Substitute("Opened $0 log block containers 
in $1",
              :                               
local_report.stats.lbm_container_count, dir->dir());
              :       last_opened_container_log_time = now;
              :     }
> KLOG_EVERY_N_SECS() does log for the first container opened no matter how l
Fine, that sounds good to me. If it's preferred to have some custom behavior, 
then KLOG_EVERY_N_SECS() is not the best options, probably.


-- 
To view, visit http://gerrit.cloudera.org:8080/7111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dd5eccd166ae81be26d0aa75758539f84d62656
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <[email protected]>
Gerrit-HasComments: Yes

Reply via email to