Adar Dembo has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7111/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1845: MonoTime last_opened_container_log_time = MonoTime::Now(); Nit: remove the "log" infix; it's not clear what a "container log" is, or "log time". But "last_opened_container_time" is pretty clear. Line 2019: // Log number of containers opened every 10 seconds Nit: terminate the comment with a period. Also, I'd adjust the comment to generalize a little bit and clarify intent: "Periodically log the number of opened containers so as to provide a progress update." By removing "10 seconds" from the comment there's one less line of code to update if we decide to change 10 to 15 or whatever. -- To view, visit http://gerrit.cloudera.org:8080/7111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dd5eccd166ae81be26d0aa75758539f84d62656 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-HasComments: Yes
