Alexey Serbin has posted comments on this change. Change subject: Add option to set CWD to Subprocess ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7176/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS2, Line 140: Test that environment variables can be passed to the subprocess stale comment? http://gerrit.cloudera.org:8080/#/c/7176/2/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 426: PLOG(ERROR) << "Unable to set subprocess current directory to " << cwd_; > Would logging rc be useful here? rc here is -1, and PLOG() will output information on errno. http://gerrit.cloudera.org:8080/#/c/7176/2/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: PS2, Line 80: SetCurrentDir maybe, rename it into SetStartDir() to emphasize that the directory is set when the process starts? -- To view, visit http://gerrit.cloudera.org:8080/7176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73dc4983b0074312623790ce026e6ad88439df89 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
