Adar Dembo has posted comments on this change. Change subject: Add option to set CWD to Subprocess ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7176/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS2, Line 150: p.ShareParentStdout(false); : ASSERT_OK(p.Start()); : int rc; : ASSERT_OK(p.Wait(&rc)); : EXPECT_EQ(0, rc); : } > Done I'm surprised this works; I thought the out-param of Wait() is the raw value from waitpid(), which can include bits that aren't part of the subprocess' exit status. http://gerrit.cloudera.org:8080/#/c/7176/4/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: Line 150: p.ShareParentStdout(false); Don't need this anymore? -- To view, visit http://gerrit.cloudera.org:8080/7176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73dc4983b0074312623790ce026e6ad88439df89 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
