Dan Burkert has posted comments on this change. Change subject: Add option to set CWD to Subprocess ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7176/4/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: Line 150: FILE* in = fdopen(p.from_child_stdout_fd(), "r"); > Don't need this anymore? It cuts down on unnecessary test output. http://gerrit.cloudera.org:8080/#/c/7176/2/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: PS2, Line 80: SetCurrentDir > Do you think it's worth re-naming it into SetStartDir() or something like t I'm not in favor of renaming it, because 'current working directory' has a known meaning in unix. I'll add to the comment. -- To view, visit http://gerrit.cloudera.org:8080/7176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73dc4983b0074312623790ce026e6ad88439df89 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
