Dan Burkert has posted comments on this change. Change subject: WIP: Add gradle build ......................................................................
Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/7258/1//COMMIT_MSG Commit Message: Line 22: - Reporting available dependency updates Nice! Line 23: - Protobuf and Avro code generation Do we use Avro for anything? http://gerrit.cloudera.org:8080/#/c/7258/1/java/README.md File java/README.md: Line 171: $ gradle :kudu-spark Why does the client build command have an additional :assemble? Line 174: to build against Spark 1 and/or Scala 2.10 Do these parameters work independently? I'm not sure we want to add Spark2/2.10 or Spark1/2.11 to our testing matrix. http://gerrit.cloudera.org:8080/#/c/7258/1/java/gradle/buildscript.gradle File java/gradle/buildscript.gradle: PS1, Line 10: cant typo: can't http://gerrit.cloudera.org:8080/#/c/7258/1/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: Line 1: apply plugin: "com.google.protobuf" Will this download a protoc for the platform? We recently added that, and it's really nice because we no longer have to do the thirdparty build just to build java. http://gerrit.cloudera.org:8080/#/c/7258/1/java/gradle/quality.gradle File java/gradle/quality.gradle: Line 13: // Configure the versions plugin to only show updates for released versions end with period http://gerrit.cloudera.org:8080/#/c/7258/1/java/kudu-flume-sink/build.gradle File java/kudu-flume-sink/build.gradle: Line 17: whitespace http://gerrit.cloudera.org:8080/#/c/7258/1/java/kudu-jepsen/build.gradle File java/kudu-jepsen/build.gradle: Line 30: // Gradle's Clojure support is fairly limited. Maybe we should consider just using lein for the clojure stuff? Since it's more-or-less disabled by default I don't think it'd be a big deal. Might make having inter-dependencies hard though. http://gerrit.cloudera.org:8080/#/c/7258/1/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ITBigLinkedList.scala File java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ITBigLinkedList.scala: Line 43: object ITBigLinkedList { This isn't actually a test class, so the rename shouldn't be necessary, right? The test class is https://github.com/apache/kudu/blob/master/java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedListTest.scala -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
