Adar Dembo has posted comments on this change. Change subject: WIP: Add gradle build ......................................................................
Patch Set 2: (3 comments) Just getting the lay of the land. I would appreciate many more code comments, even on very basic and perhaps obvious gradle-y stuff. That will help the rest of us gradle newbs understand how it works. Put another way, imagine that you're writing a gradle tutorial, and you've chosen to use the Kudu Java client as the basis for the tutorial. If you wouldn't mind going into that level of detail and explaining how everything works in code comments and text blocks, I think the transition to gradle could happen faster as we'd learn how to use it really quickly. http://gerrit.cloudera.org:8080/#/c/7258/2/java/build.gradle File java/build.gradle: Line 9: subprojects { What motivated this decomposition? Is it idiomatic for gradle? Or just something that felt right to you? Line 11: apply from: "$rootDir/gradle/scopes.gradle" Can these be sorted alphabetically? If not, could you add comments to explain why they're in this order? http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradlew File java/gradlew: Line 1: #!/usr/bin/env sh > This is a generated file by running 'gradle wrapper'. Do generated files ha If it's a generated file, why are we checking it in? Shouldn't it just be regenerated by each developer before using gradle? -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
