Grant Henke has posted comments on this change. Change subject: WIP: Add gradle build ......................................................................
Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/7258/1//COMMIT_MSG Commit Message: Line 23: - Protobuf and Avro code generation > Do we use Avro for anything? The kudu-flume-sink leverages avro in the unit tests. http://gerrit.cloudera.org:8080/#/c/7258/1/java/README.md File java/README.md: Line 171: $ gradle :kudu-spark:assemble > Why does the client build command have an additional :assemble? Ah I just left it off of this command on accident. This is the syntax to reference a task for a submodule only instead of the entire build even when at the parent directory. Line 174: to build against Spark 1 and/or Scala 2.10 > Do these parameters work independently? I'm not sure we want to add Spark2 Currently they do work independently. http://gerrit.cloudera.org:8080/#/c/7258/1/java/gradle/buildscript.gradle File java/gradle/buildscript.gradle: Line 10: // Manage plugin dependencies since the plugin block can't be used in included build scripts yet. > typo: can't Done http://gerrit.cloudera.org:8080/#/c/7258/1/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: Line 1: apply plugin: "com.google.protobuf" > Will this download a protoc for the platform? We recently added that, and Yes, this continues to work the same way the maven build does. Specifically because of the "artifact =" line below that instructs the plugin to use maven for protoc. All of the platform detection is included by default. http://gerrit.cloudera.org:8080/#/c/7258/1/java/gradle/quality.gradle File java/gradle/quality.gradle: Line 13: // Configure the versions plugin to only show updates for released versions. > end with period Done http://gerrit.cloudera.org:8080/#/c/7258/1/java/kudu-flume-sink/build.gradle File java/kudu-flume-sink/build.gradle: Line 17 > whitespace Done http://gerrit.cloudera.org:8080/#/c/7258/1/java/kudu-jepsen/build.gradle File java/kudu-jepsen/build.gradle: Line 30: // Gradle's Clojure support is fairly limited. > Maybe we should consider just using lein for the clojure stuff? Since it's I don't think inter-dependencies is a big deal here. I can look into other options like lein. But from initial searches its just a language that has got less attention on Gradle. Note: This does still work as is. Its just a bit weird since it doesn't follow usual gradle conventions. http://gerrit.cloudera.org:8080/#/c/7258/1/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ITBigLinkedList.scala File java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ITBigLinkedList.scala: Line 43 > This isn't actually a test class, so the rename shouldn't be necessary, rig My mistake. I was changing it back and forth and changed the wrong one in the end. -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
