Dan Burkert has posted comments on this change. Change subject: Add mustache as a dependency ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7298/2//COMMIT_MSG Commit Message: Line 7: Add mustache as a dependency Please also add an entry in thirdparty/LICENSE.txt http://gerrit.cloudera.org:8080/#/c/7298/2/CMakeLists.txt File CMakeLists.txt: Line 860: extra newline http://gerrit.cloudera.org:8080/#/c/7298/2/src/kudu/server/default-path-handlers.cc File src/kudu/server/default-path-handlers.cc: Line 31: #include <mustache.h> The changes in this file aren't needed, right? http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/vars.sh File thirdparty/vars.sh: Line 99: # (from https://github.com/henryr/cpp-mustache) extra whitespace -- To view, visit http://gerrit.cloudera.org:8080/7298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
