Adar Dembo has posted comments on this change. Change subject: Add mustache as a dependency ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 503: ${CXX:-g++} $EXTRA_CXX_FLAGS -I$PREFIX/include -I$TP_DIR/installed/common/include -O3 -DNDEBUG -fPIC -c "$MUSTACHE_SOURCE/mustache.cc" EXTRA_CXX_FLAGS isn't a real variable; I think you meant EXTRA_CXXFLAGS here. Also, why do we need these -I entries? -- To view, visit http://gerrit.cloudera.org:8080/7298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
