Sam Okrent has posted comments on this change. Change subject: Add mustache as a dependency ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7298/2//COMMIT_MSG Commit Message: Line 7: Add mustache as a dependency > Please also add an entry in thirdparty/LICENSE.txt Done http://gerrit.cloudera.org:8080/#/c/7298/2/CMakeLists.txt File CMakeLists.txt: Line 860: ## OpenSSL > extra newline Done http://gerrit.cloudera.org:8080/#/c/7298/3/thirdparty/LICENSE.txt File thirdparty/LICENSE.txt: Line 246: -------------------------------------------------------------------------------- > Nit: looks like you left off a dash or two here. Can't tell which of the tw Done http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 503: # We add $PREFIX/include for boost and $PREFIX_COMMON/include for rapidjson. > You can use PREFIX_COMMON for $TP_DIR/installed/common. Please also add a c Done http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/vars.sh File thirdparty/vars.sh: Line 99: # (from https://github.com/henryr/cpp-mustache) > extra whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/7298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058c19ef32e80f122bfa125de42c39d52286e796 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
