Hao Hao has posted comments on this change. Change subject: [WIP] Add BlockDeletionTransaction to Block Manager ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7656/1/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: Line 537: explicit FileBlockDeletionTransaction( > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/7656/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1137: explicit LogBlockDeletionTransaction(LogBlockManager* block_manager); > warning: single-argument constructors must be marked explicit to avoid unin Done Line 1160: BlockDataByContainerMap deleted_block_map_; > warning: invalid case style for private member 'deleted_block_map' [readabi Done Line 1271: void LogBlock::RegisterDeletion( > warning: the parameter 'transaction' is copied for each invocation but only Done -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
