Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7656/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: PS6, Line 165: deletion > deletions Done Line 170: class BlockDeletionTransaction : public RefCountedThreadSafe<BlockDeletionTransaction> { > Would prefer if this used std::shared_ptr rather than scoped_refptr. We gen Sure, just curious I saw in our contribution page (https://kudu.apache.org/docs/contributing.html#_pointers), saying that 'Since scoped_refptr is generally faster and smaller, try to use it rather than shared_ptr in new code.' Is this statement outdated? Not sure if I missed something? Line 288: class BlockCreationTransaction { > Could you do this rename as part of a separate patch? It's clearly a trivia Thanks for the suggestion! Done. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
