Hao Hao has posted comments on this change. Change subject: KUDU-2055: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7656/2/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 182: > I think the docs on the 'deleted' parameter could use some work here - I'm Done Line 273: // Returned block IDs are not guaranteed to be in any particular order, > Since this is infallible (doesn't return Status), could it return the scope Done http://gerrit.cloudera.org:8080/#/c/7656/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1184: std::sort(log_blocks.begin(), log_blocks.end(), > Not continue? Done Line 1217: // If we cannot find the block, then the block could be actually > can drop the std:: prefix Done Line 1225: deleted.emplace_back(block); > lowercase first letter Done Line 1983: > consider using CreateDeletionTransaction That would introduce a downcast? PS2, Line 2173: d > lowercase first letter Done -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
