Andrew Wong has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7766/4/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: PS4, Line 597: TODO(awong): currently the FsReport only reports on containers for the : // log block manager. Implement some sort of reporting for failed : // directories as well. > mind creating a jira to track this and assigning to yourself? Done http://gerrit.cloudera.org:8080/#/c/7766/4/src/kudu/integration-tests/disk_failure-itest.cc File src/kudu/integration-tests/disk_failure-itest.cc: PS4, Line 104: Substitute("--env_inject_eio_globs=$0", JoinPathSegments(failed_dir, "**")), : "--env_inject_eio=1.0", : "--suicide_on_eio=false", > what if you just append to the current flags and not replace them all? Done -- To view, visit http://gerrit.cloudera.org:8080/7766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3fae98355657f6aa4b134c542f92fc07f5c0aa1 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
