Andrew Wong has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks ......................................................................
Patch Set 5: (6 comments) I'm using a cluster verifier, but it doesn't quite work if you mix around the block manager type. I've deparameterized the test for this reason. http://gerrit.cloudera.org:8080/#/c/7766/4/src/kudu/integration-tests/disk_failure-itest.cc File src/kudu/integration-tests/disk_failure-itest.cc: Line 31: METRIC_DECLARE_gauge_uint64(data_dirs_failed); > not used in an external minicluster test As per our hipchat convo, this is needed to get metric. Line 33: DECLARE_string(block_manager); > same Done PS4, Line 42: > does 30 work? Done Line 55: StartCluster(GetClusterFlags(), {}, 3, 5); > I dont think you need this when you can just use cluster_->tablet_server(i) Done PS4, Line 96: ExternalTabletServer* ts = cluster_->tablet_server(0); : ASSERT_OK(cluster_->WaitForTabletsRunning(ts, kNumTablets, kAgreementTimeout)); : > how about: I'm going to keep this here since it's just a way to ensure we don't restart before things are persisted. I'll use the cluster verifier below. PS4, Line 116: } : > additionally, how about adding: See above comment. -- To view, visit http://gerrit.cloudera.org:8080/7766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3fae98355657f6aa4b134c542f92fc07f5c0aa1 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
