Mike Percy has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7766/4/src/kudu/integration-tests/disk_failure-itest.cc File src/kudu/integration-tests/disk_failure-itest.cc: Line 31: METRIC_DECLARE_gauge_uint64(data_dirs_failed); not used in an external minicluster test Line 33: DECLARE_string(block_manager); same PS4, Line 42: 120 does 30 work? Line 55: void SetupDefaultCluster(vector<ExternalTabletServer*>* ext_tservers) { I dont think you need this when you can just use cluster_->tablet_server(i) to get what you are loading into this vector PS4, Line 96: // Ensure the tablets get to a running state. : ASSERT_OK(cluster_->WaitForTabletsRunning(cluster_->tablet_server(0), : kNumTablets, kAgreementTimeout)); how about: auto& ts0 = ts_map_[cluster_->tablet_server(0)->uuid()]; string tablet_id; ASSERT_EVENTUALLY([&] { vector<string> tablet_ids; ASSERT_OK(ListRunningTabletIds(ts0, kTimeout, &tablet_ids)); ASSERT_EQ(1, tablet_ids.size()); tablet_id = tablet_ids[0]; } ASSERT_OK(WaitForServersToAgree(kTimeout, ts_map_, tablet_id, workload.batches_completed())); PS4, Line 116: ASSERT_OK(cluster_->WaitForTabletsRunning(cluster_->tablet_server(0), : kNumTablets, kAgreementTimeout)); additionally, how about adding: ASSERT_OK(WaitForServersToAgree(kTimeout, ts_map_, tablet_id, workload.batches_completed())); -- To view, visit http://gerrit.cloudera.org:8080/7766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3fae98355657f6aa4b134c542f92fc07f5c0aa1 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
