Mike Percy has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files ......................................................................
Patch Set 3: Code-Review+1 (1 comment) looks good, just a comment nit http://gerrit.cloudera.org:8080/#/c/7927/3/java/gradlew File java/gradlew: PS3, Line 40: # Run the real wrapper. By using 'source' we can trick the APP_HOME detection : # in gradlew to think that APP_HOME=$JAVA_DIR. That way it'll naturally find : # the gradle wrapper content in the gradle/wrapper subdirectory. How about something like: Run the "real" gradlew script. Even though we downloaded it into the wrapper/ directory, if we invoke it via 'source' it will be tricked into thinking it is running from the java root directory, which is where it expects to live. That way it'll naturally find the gradle wrapper content in the gradle/wrapper subdirectory. -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
