Mike Percy has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files ......................................................................
Patch Set 4: > Sorry on phone it won't let me post inthe thread. I don't see why > the graders case needs to be explained further. It's no different > than the have files a line above. OK, your argument is convincing. I would be more comfortable if the included file(s) had copyright notices or something mentioning the Gradle project (in order to indicate provenance) but I suppose the fact that it's "gradlew" is clear enough where it came from and due to the ASL 2.0 license, attribution is not required. So +2 from me on Patch Set 2. -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: No
