Dan Burkert has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7927/2/LICENSE.txt File LICENSE.txt: Line 563: java/gradlew: Apache 2.0 license > I think we should add something like: 'this file'? Wouldn't that refer to LICENSE.txt in this context? http://gerrit.cloudera.org:8080/#/c/7927/2/java/gradlew File java/gradlew: Line 3: # Copyright 2017 the original author or authors. > how about: the original author or authors from the Gradle project. This is what a bunch of license headers look like in Gradle. We don't necessarily know that the Gradle project holds copyright on this file. -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
