Adar Dembo has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7966/1//COMMIT_MSG Commit Message: PS1, Line 10: expires to expire http://gerrit.cloudera.org:8080/#/c/7966/1/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: Line 125: Status Commit(fs::BlockTransaction* transaction); Why not do this as part of Finish? You could make the BlockTransaction part of TabletCopyClient to avoid passing it back and forth too. -- To view, visit http://gerrit.cloudera.org:8080/7966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4feabc08c2199aad8d08be56f09ac06924345f2b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
