Hao Hao has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy ......................................................................
Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/7966/3/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: Line 365: // Defer the closures of all downloaded blocks to here, but before superblock > Add a comment explaining why this happens before superblock replacement. Done http://gerrit.cloudera.org:8080/#/c/7966/3/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: PS3, Line 115: Add > Adds, but this comment isn't quite right since the transaction is no longer Done PS3, Line 168: ransaction. > tablet copy's transaction Done PS3, Line 168: to the tablet > Just remove this. Done PS3, Line 176: tablet copy's transaction > tablet copy's transaction Done PS3, Line 189: tablet copy's transaction > tablet copy's transaction Done http://gerrit.cloudera.org:8080/#/c/7966/3/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS3, Line 577: if (!s.ok()) { : LOG(WARNING) << LogPrefix(tablet_id) << "Tablet Copy: Unable to fetch data from remote peer " : << kSrcPeerInfo << ": " << s.ToString(); : return; > This comment is no longer relevant here. Done Line 590: << s.ToString(); > This comment is no longer relevant here. Done -- To view, visit http://gerrit.cloudera.org:8080/7966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4feabc08c2199aad8d08be56f09ac06924345f2b Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
