Adar Dembo has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy ......................................................................
Patch Set 3: (8 comments) The test failure is unrelated to your change. http://gerrit.cloudera.org:8080/#/c/7966/3/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: Line 365: RETURN_NOT_OK(transaction_.CommitCreatedBlocks()); Add a comment explaining why this happens before superblock replacement. http://gerrit.cloudera.org:8080/#/c/7966/3/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: PS3, Line 115: Add Adds, but this comment isn't quite right since the transaction is no longer 'given' as an argument. PS3, Line 168: during copying Just remove this. PS3, Line 168: transaction of table copy tablet copy's transaction PS3, Line 176: transaction of table copy tablet copy's transaction PS3, Line 189: transaction of table copy tablet copy's transaction http://gerrit.cloudera.org:8080/#/c/7966/3/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS3, Line 577: // Defer closures of all downloaded blocks to Finish() for two main reasons: : // 1) If DownloadWALs() fails there's no reason to commit all those blocks and do sync(). : // 2) While DownloadWALs() is running the kernel has more time to eagerly flush the blocks, : // so the fsync() operations could be cheaper. This comment is no longer relevant here. Line 590: // Commit all downloaded blocks. This comment is no longer relevant here. -- To view, visit http://gerrit.cloudera.org:8080/7966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4feabc08c2199aad8d08be56f09ac06924345f2b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
