Dan Burkert has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy ......................................................................
Patch Set 5: Code-Review+1 (2 comments) Looks good, I like how this makes the code a bit simpler (less parameters passed around). http://gerrit.cloudera.org:8080/#/c/7966/5//COMMIT_MSG Commit Message: PS5, Line 14: seesion session http://gerrit.cloudera.org:8080/#/c/7966/5/src/kudu/tserver/tablet_copy_client-test.cc File src/kudu/tserver/tablet_copy_client-test.cc: Line 180: ASSERT_OK(client_->transaction_.CommitCreatedBlocks()); Should these be calling Finish instead of reaching into the transaction manually? -- To view, visit http://gerrit.cloudera.org:8080/7966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4feabc08c2199aad8d08be56f09ac06924345f2b Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
