Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/7656/6//COMMIT_MSG Commit Message: PS6, Line 14: hole punching > holes punched Done Line 15: will be reduced from one per block to one per log block container. > That's assuming that the individual holes are all contiguous. In the worst Right. Thanks for catching it. PS6, Line 17: compaction > I actually think tablet deletion is a better example, since that'll delete Done PS6, Line 19: serial > series Done http://gerrit.cloudera.org:8080/#/c/7656/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 170: class BlockDeletionTransaction : public RefCountedThreadSafe<BlockDeletionTransaction> { > Yeah, I think Dan mentioned this to me the other day. I see, thanks! Would you mind I make it shard_ptr in next patch. After thinking more I would like to narrow down the scope of this patch just to introduce BlockDeletionTransaction. Line 180: virtual std::vector<BlockId> MarkDeletions(std::vector<BlockId> blocks) = 0; > I think this should be structured like BlockCreationTransaction in that: Done PS6, Line 259: // Creates a new block deletion transaction block, which can be used : // to coalesce a group of block deletions. : virtual scoped_refptr<BlockDeletionTransaction> CreateDeletionTransaction() = 0; > Can we start with BlockDeletionTransaction behaving more like BlockCreation Done -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
