Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/8328 )
Change subject: WIP: [tls_socket] retry IO on SSL_ERROR_WANT_{READ,WRITE}
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8328/1/src/kudu/security/tls_socket.cc
File src/kudu/security/tls_socket.cc:
http://gerrit.cloudera.org:8080/#/c/8328/1/src/kudu/security/tls_socket.cc@72
PS1, Line 72: continue;
is this dangerous in the case where the socket is set to non-blocking? (ie in
the context of the reactor thread). I could see this ending up looping
indefinitely in the reactor thread which would be bad news.
--
To view, visit http://gerrit.cloudera.org:8080/8328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72b2050d1aa683731faa02b2adb360d46cd0f94c
Gerrit-Change-Number: 8328
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Thu, 19 Oct 2017 03:39:40 +0000
Gerrit-HasComments: Yes
