Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 )
Change subject: [tls_socket] workaround for TLS short read ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8328/2/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: http://gerrit.cloudera.org:8080/#/c/8328/2/src/kudu/security/tls_socket.cc@77 PS2, Line 77: if (is_non_blocking_) { > would it be sufficient to check errno here? ie would errno just propagate o It's good idea. However, I'm not sure errno is set to EAGAIN or EINTR here. I'll check. -- To view, visit http://gerrit.cloudera.org:8080/8328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72b2050d1aa683731faa02b2adb360d46cd0f94c Gerrit-Change-Number: 8328 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 Nov 2017 01:11:58 +0000 Gerrit-HasComments: Yes
