Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 )
Change subject: [tls_socket] workaround for TLS short read ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8328/2/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: http://gerrit.cloudera.org:8080/#/c/8328/2/src/kudu/security/tls_socket.cc@46 PS2, Line 46: is_non_blocking_ = flags & FLAG_NONBLOCKING; this seems a little fragile, but maybe not necessary if the below suggestion works OK http://gerrit.cloudera.org:8080/#/c/8328/2/src/kudu/security/tls_socket.cc@77 PS2, Line 77: if (is_non_blocking_) { would it be sufficient to check errno here? ie would errno just propagate out of openssl properly so we can return NetworkError with posix_code set to errno, like the normal socket does? then we don't need to treat is_non_blocking differently than blocking, because callers expect NetworkError with appropriate posix code. http://gerrit.cloudera.org:8080/#/c/8328/2/src/kudu/security/tls_socket.cc@91 PS2, Line 91: } while (true); I don't think this necessarily has to loop, so long as we pass up the appropriate "temporary socket error" to higher levels -- To view, visit http://gerrit.cloudera.org:8080/8328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72b2050d1aa683731faa02b2adb360d46cd0f94c Gerrit-Change-Number: 8328 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 Nov 2017 01:08:26 +0000 Gerrit-HasComments: Yes
