Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8451 )
Change subject: KUDU-1578. Hybrid clock should ride over brief interruptions in NTP service ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8451/3/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/8451/3/src/kudu/clock/hybrid_clock.cc@174 PS3, Line 174: Status s = WalltimeWithError Would it make sense to at least output a warning here? >From the implementation of WalltimeWithError() I see both now_usec and >error_usec are initialized even the function returned an error, but from >reader's perspective it's not easy to get used to the fact that now_usec and >error_usec are used below after WalltimeWithError returns non-OK status. >Maybe, it's worth modifying the signature of the WalltimeWithError() to return >the status as out parameter as well? http://gerrit.cloudera.org:8080/#/c/8451/3/src/kudu/clock/hybrid_clock.cc@359 PS3, Line 359: MonoDelta time_since_read = read_time - last_clock_read_time_; what if l.owns_lock() returns false at line 339? Is it valid to operate with non-initialized read_time like this? -- To view, visit http://gerrit.cloudera.org:8080/8451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d03a77033070e6bcdfdefc4341981f28a1477a0 Gerrit-Change-Number: 8451 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 02 Nov 2017 22:01:19 +0000 Gerrit-HasComments: Yes
