Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8451 )
Change subject: KUDU-1578. Hybrid clock should ride over brief interruptions in NTP service ...................................................................... KUDU-1578. Hybrid clock should ride over brief interruptions in NTP service This changes HybridClock so that, if the clock loses synchronization for a brief period of time, it will continue to use the most recent clock reading, adjusting it forward based on the local monotonic clock and a conservative estimate for max error. In the case that the clock is out of sync for a significantly long time, the max error will grow large enough to eclipse the 10-second default, at which point it will still crash as before. But, if NTP is properly restored within a few minutes, the server should remain operational. A simple test is included which injects a fake error into the NTP source. I also ran a kudu-master while briefly disabling NTP and ensured that the log messages showed up as expected and then went away when I resumed NTP synchronization. Change-Id: I0d03a77033070e6bcdfdefc4341981f28a1477a0 Reviewed-on: http://gerrit.cloudera.org:8080/8451 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Todd Lipcon <[email protected]> --- M src/kudu/clock/hybrid_clock-test.cc M src/kudu/clock/hybrid_clock.cc M src/kudu/clock/hybrid_clock.h M src/kudu/clock/system_ntp.cc 4 files changed, 119 insertions(+), 12 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/8451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0d03a77033070e6bcdfdefc4341981f28a1477a0 Gerrit-Change-Number: 8451 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
