Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8451 )
Change subject: KUDU-1578. Hybrid clock should ride over brief interruptions in NTP service ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8451/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8451/3//COMMIT_MSG@16 PS3, Line 16: ntp nit: NTP http://gerrit.cloudera.org:8080/#/c/8451/3//COMMIT_MSG@16 PS3, Line 16: crash as before Is this still valid? I see this would happen if calling HybridClock::IsAfter(), not I'm sure it will happen elsewhere. http://gerrit.cloudera.org:8080/#/c/8451/3//COMMIT_MSG@20 PS3, Line 20: ntp nit: NTP http://gerrit.cloudera.org:8080/#/c/8451/3//COMMIT_MSG@22 PS3, Line 22: ntp nit: NTP -- To view, visit http://gerrit.cloudera.org:8080/8451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d03a77033070e6bcdfdefc4341981f28a1477a0 Gerrit-Change-Number: 8451 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 02 Nov 2017 22:11:53 +0000 Gerrit-HasComments: Yes
