Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8387 )
Change subject: disk failure: randomized tserver test ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@364 PS5, Line 364: typedef vector<RowOperationsPB::Type> OpTypeList; this is a long test, should only run in AllowSlowTests() mode http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@378 PS5, Line 378: NO_FATALS(ShutdownTablet()); : NO_FATALS(StartTabletServer(/*num_data_dirs=*/ kNumDirs)); this is a little awkward; why not just create a new test case class / file for this test that inherits from the same base class but has its own SetUp() ? http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@447 PS5, Line 447: ASSERT_FALSE(s.ok()); we're ignoring 99% of the PerformOp() status returns, right? Why not ASSERT_OK() on each one? http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@451 PS5, Line 451: nit: random extra line http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@452 PS5, Line 452: ASSERT_TRUE(tablet_replica_->state() == tablet::FAILED) nit: ASSERT_EQ(tablet::FAILED, tablet_replica_->state()) http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@457 PS5, Line 457: FLAGS_env_inject_eio = 0; nit: no need to reset the flag because a FlagSaver member is built into the KuduTest base class -- To view, visit http://gerrit.cloudera.org:8080/8387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17aca35fc0bf9c7b1b73308def865b0ed48d07fa Gerrit-Change-Number: 8387 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2017 00:53:30 +0000 Gerrit-HasComments: Yes
