Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8387 )

Change subject: disk failure: randomized tserver test
......................................................................


Patch Set 7:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@361
PS6, Line 361:  TabletServerTes
> TabletServerTestBase
Done


http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@361
PS6, Line 361:
> nit: missing space before colon on this line
Done


http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@365
PS6, Line 365: TabletServerTest
> TabletServerTestBase
Done


http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@374
PS6, Line 374:     NO_FATALS(StartTabletServer(/*num_data_dirs=*/ kNumDirs));
> There is no need to shut down if you inherit from the base class since noth
Done



--
To view, visit http://gerrit.cloudera.org:8080/8387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17aca35fc0bf9c7b1b73308def865b0ed48d07fa
Gerrit-Change-Number: 8387
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Wed, 29 Nov 2017 03:08:23 +0000
Gerrit-HasComments: Yes

Reply via email to