Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8387 )
Change subject: disk failure: randomized tserver test ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8387/5/src/kudu/tserver/tablet_server-test.cc@447 PS5, Line 447: // At this point, a bunch of operations have gone through successfully. Fail > Here we're going until we eventually fail, so this is more of an ASSERT_EVE k http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@361 PS6, Line 361: TabletServerTest TabletServerTestBase http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@361 PS6, Line 361: : nit: missing space before colon on this line http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@365 PS6, Line 365: TabletServerTest TabletServerTestBase http://gerrit.cloudera.org:8080/#/c/8387/6/src/kudu/tserver/tablet_server-test.cc@374 PS6, Line 374: NO_FATALS(ShutdownTablet()); There is no need to shut down if you inherit from the base class since nothing has started -- To view, visit http://gerrit.cloudera.org:8080/8387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17aca35fc0bf9c7b1b73308def865b0ed48d07fa Gerrit-Change-Number: 8387 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2017 02:52:53 +0000 Gerrit-HasComments: Yes
