Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 )
Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8951/1/src/kudu/integration-tests/heavy-update-compaction-test.cc File src/kudu/integration-tests/heavy-update-compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/8951/1/src/kudu/integration-tests/heavy-update-compaction-test.cc@46 PS1, Line 46: How many rounds will be performed > rounds of what? Done http://gerrit.cloudera.org:8080/#/c/8951/1/src/kudu/integration-tests/heavy-update-compaction-test.cc@145 PS1, Line 145: HeavyUpdateCompactionTest > any way to add verification that not only did it not overflow but that the What are you thinking? As a repro for KUDU2231 this test is extremely timing dependent, so I think scanning in between every round is going to make it less effective. http://gerrit.cloudera.org:8080/#/c/8951/1/src/kudu/integration-tests/heavy-update-compaction-test.cc@175 PS1, Line 175: void > why have this last? moved. Docs are on the decl. -- To view, visit http://gerrit.cloudera.org:8080/8951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74975cdab605b51617d93d1ae98ef72ce87e35cb Gerrit-Change-Number: 8951 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 05 Jan 2018 21:02:39 +0000 Gerrit-HasComments: Yes
